migration: don't delete old PVC by default during upgrade (PROJQUAY-7182) #919
Conversation
|
/retest |
| if os.Getenv("POSTGRES_UPGRADE_RETAIN_BACKUP") == "true" { | ||
| continue | ||
| } | ||
| //if os.Getenv("POSTGRES_UPGRADE_RETAIN_BACKUP") == "true" { |
There was a problem hiding this comment.
Instead of removing this completely, can we just reverse the flag? To something like POSTGRES_UPGRADE_DELETE_BACKUP ?
There was a problem hiding this comment.
sure, that's a good idea
Sunandadadi
force-pushed
the
PROJQUAY-7182
branch
from
02a28a0 to
5013ce2
Compare
Sunandadadi
force-pushed
the
PROJQUAY-7182
branch
from
5013ce2 to
56ffc33
Compare
|
/retest |
|
/cherrypick redhat-3.11 |
|
@Sunandadadi: new pull request created: #921 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick redhat-3.10 |
|
@Sunandadadi: new pull request created: #922 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick redhat-3.9 |
|
@Sunandadadi: new pull request created: #923 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Removing check to delete old PVC, don't delete it by default.